pyro-ppl/pyro

Incorrect stack terminology in Poutine and minipyro.py

Open

#3,088 opened on 2022年5月13日

GitHub で見る
 (2 comments) (0 reactions) (0 assignees)Python (8,211 stars) (981 forks)batch import
documentationhelp wanted

説明

The Poutine example page and the minipyro.py example script flip the standard terminology of the stack data structure. One adds and removes from the top of the stack, but in these pages this is flipped. As pedagogical resources, this inverted terminology adds unnecessary confusion.

For example, when iterating over the stack in minipyro.py:

PYRO_STACK is reversed so that effect handlers higher in the stack are first applied.

and in http://pyro.ai/examples/effect_handlers.html#Interlude:-the-global-Messenger-stack:

Messenger.__enter__ appends a Messenger to the end (the bottom) of the global handler stack

コントリビューターガイド

Incorrect stack terminology in Poutine and minipyro.py · pyro-ppl/pyro#3088 | Good First Issue