CheckParameterValues not replaced in inner graphs · pymc-devs/pymc#6697

(3 comments) (0 reactions) (0 assignees)Python (7,926 stars) (1,902 forks)batch import

help wantedlogprob

説明

We include these rewrites when compiling logp graphs, but this won't replace inner logp graphs (e.g, inside Scan or not-inlined OpFromGraph)

The example in #6696 suffers from this. Sampling is quite faster when the rewrite is manually added

技術スタック: python
領域: backendperformance
Issue 種別: bug
難度: 4
推定時間: half day
活動状況: stale
明確さ: clear
前提条件: Understanding of PyMC compilation pipelineFamiliarity with graph rewrites in PyTensor
初心者向け度: 30
調査方針: The issue is that the CheckParameterValues rewrite is not applied to inner graphs (e.g., inside Scan or not inlined OpFromGraph). The relevant code is at pymc/pytensorf.py lines 1142-1144. The fix would involve ensuring this rewrite is recursively applied to all subgraphs. Start by examining how rewrites are applied in the compilation process, and look at the example in issue #6696 to reproduce the performance difference. Consider modifying the rewrite application logic to traverse inner graphs.