provectus/kafka-ui

FE: Handle 504s properly

Open

#4,075 opened on 2023年8月1日

GitHub で見る
 (4 comments) (0 reactions) (0 assignees)Java (7,799 stars) (977 forks)batch import
area/uxgood first issuescope/frontendstatus/acceptedtype/bug

説明

Issue submitter TODO list

  • I've looked up my issue in FAQ
  • I've searched for an already existing issues here
  • I've tried running master-labeled docker image and the issue still persists there
  • I'm running a supported version of the application which is listed here

Describe the bug (actual behavior)

when kafka-ui can't access the remote broker, it waits for a long time (this should also have timeout). Meanwhile in the UI you see the loader in the topics page.

In the network tab I can see long request:

http://server/api/clusters/<cluster>/topics?page=1&perPage=25&showInternal=true

At some point it fails with 504, but the loader is still shown on the UI

Expected behavior

Loader should be removed and the error message should be shown

Your installation details

56fa824

Steps to reproduce

  1. make sure kafka ui can't access remote broker.
  2. visit topics page in that cluster

Screenshots

No response

Logs

no logs in the app output

Additional context

No response

コントリビューターガイド

技術スタック
なし
領域
frontend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
fresh
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
Basic frontend developmentUnderstanding of HTTP error handling
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
75
調査方針
Investigate the frontend's API request handling, likely in the Topics page component. Look for where the loader is controlled and add error handling for 504 responses to display an error message instead of keeping the loader. Check if there is an existing error state pattern in the codebase, possibly in the network layer (e.g., axios interceptors) or within the component itself. Reference the commit 56fa824 if available.
FE: Handle 504s properly · provectus/kafka-ui#4075 | Good First Issue