protocolbuffers/protobuf

Generated PHP code with incorrect comment formating

Open

#14,563 opened on 2023年10月31日

GitHub で見る
 (1 comment) (0 reactions) (0 assignees)C++ (16,128 forks)batch import
help wantedphp

Repository metrics

Stars
 (71,223 stars)
PR merge metrics
 (平均マージ 2d 11h) (30d で 185 merged PRs)

説明

Language: PHP

What did you do? Steps to reproduce the behavior:

  1. Go to https://github.com/googleapis/google-cloud-php/pull/6737/files
  2. Click on Dataform/src/V1beta1/Client/DataformClient.php
  3. Scroll down to setIamPolicy and see the code block over the method, it has missing asterisk sign in comments.

What did you expect to see All comments start with asterisk.

What did you see instead? ref

/**
     * Sets the access control policy on the specified resource. Replaces
    any existing policy.

    Can return `NOT_FOUND`, `INVALID_ARGUMENT`, and `PERMISSION_DENIED`
    errors.
     *
     * The async variant is {@see DataformClient::setIamPolicyAsync()} .
     *

コントリビューターガイド