probcomp/bayeslite

latent variables cannot be inputs to CGPM foreign models

Open

#445 opened on 2016年7月12日

GitHub で見る
 (0 comments) (0 reactions) (0 assignees)Python (915 stars) (63 forks)batch import
help wantedk min/hr

説明

create generator g for p using cgpm (
    model foo given err using venturescript (sp = errfoo),
    latent err numerical
)

This will not work because cgpm_metamodel._create_schema assumes that every input to a foreign model exists as a manifest variable of the population, and passes them to core.bayesdb_variable_stattype to determine the statistical type.

The logic in _create_schema must be changed to defer whatever processing requires the statistical types of inputs to foreign models until after all clauses have been ingested, and then update that processing to use latents (the mapping from latent variable names to their respective statistical types) instead of core.bayesdb_variable_stattype when appropriate.

コントリビューターガイド

技術スタック
python
領域
backenddata
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
4
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
Pythonbayeslite internalsCGPM conceptbasic Bayesian statistics
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
10
調査方針
The issue is in `cgpm metamodel. create schema` in the bayeslite codebase. It currently assumes all inputs to foreign models are manifest variables, but latent variables should also be allowed. The fix requires deferring the statistical type determination for foreign model inputs until after all clauses are processed, then using the `latents` mapping instead of `core.bayesdb variable stattype`. Start by examining the ` create schema` method and understanding how it processes foreign models, then design a change that separates the input validation from type resolution.
latent variables cannot be inputs to CGPM foreign models · probcomp/bayeslite#445 | Good First Issue