probcomp/bayeslite

latent variables cannot be inputs to CGPM foreign models

オープン

#445 opened on 2016/07/12

 (0 件のコメント) (0 件のリアクション) (0 人の担当者)Python (63 件のフォーク)batch import
help wantedk min/hr

Repository metrics

Stars
 (915 個のスター)
PR merge metrics
 (30d に merged PR はありません)

説明

create generator g for p using cgpm (
    model foo given err using venturescript (sp = errfoo),
    latent err numerical
)

This will not work because cgpm_metamodel._create_schema assumes that every input to a foreign model exists as a manifest variable of the population, and passes them to core.bayesdb_variable_stattype to determine the statistical type.

The logic in _create_schema must be changed to defer whatever processing requires the statistical types of inputs to foreign models until after all clauses have been ingested, and then update that processing to use latents (the mapping from latent variable names to their respective statistical types) instead of core.bayesdb_variable_stattype when appropriate.

コントリビューターガイド