prestodb/presto

[native] Make "memory-pool-init-capacity" and "memory-pool-transfer-capacity" registered SystemConfig properties

Open

#21,345 opened on 2023年11月8日

GitHub で見る
 (4 comments) (1 reaction) (1 assignee)Java (5,240 forks)batch import
buggood first issue

Repository metrics

Stars
 (15,558 stars)
PR merge metrics
 (平均マージ 34d 14h) (30d で 120 merged PRs)

説明

memory-pool-init-capacity and memory-pool-transfer-capacity are not registered SystemConfig properties in https://github.com/prestodb/presto/blob/master/presto-native-execution/presto_cpp/main/common/Configs.cpp#L131

This leads to warnings ("Unregistered properties from ...") during server initialization. This is misleading.

These properties should be registered SystemConfig properties.

Steps to Reproduce

Add entries for memory-pool-init-capacity and memory-pool-transfer-capacity in config.properties and start Prestissimo

"memory-arbitrator-kind": "SHARED"
"memory-pool-init-capacity": "536870912"
"memory-pool-transfer-capacity": "536870912"

コントリビューターガイド