child visible property toggles from true to false without re-render · preactjs/preact-compat#311

(8 comments) (0 reactions) (0 assignees)JavaScript (952 stars) (148 forks)batch import

help wanted

説明

In my test project: https://github.com/MichaelRando/preact-rollup-bootstrap pressing button 'Test Dialog' displays a test dialog, by virtue of setting the state variable to true and the Dialog's visible property is set to said state. Clicking off or closing the dialog is expected to hide the dialog's view. When using react & react-dom, the dialog appears and disappears as many times as the user could want, successfully. When using preact & preact-compat, the dialog appears successfully, but closing / setting the visible state false has no effect. The Dialog component is not re-rendering as React compatibility would expect. This is a super basic test; not sure why this is happening.

コントリビューターガイド

技術スタック: javascriptreact
領域: frontend
Issue 種別: bug
難度: 3
推定時間: half day
活動状況: stale
明確さ: mostly clear
前提条件: React basicsPreact compatible components
初心者向け度: 45
調査方針: Investigate the dialog visibility toggle bug in preact compat by reviewing the 8 comments for debugging hints. The linked test project (github.com/MichaelRando/preact rollup bootstrap) reproduces the issue. Compare how preact compat handles child visibility vs. React. The compatibility layer has since moved to the main preact repo; check if the bug persists there and consider porting the fix.