plotly/falcon

Refactor Preview.react.js and Settings.react.js

オープン

#362 opened on 2018/02/01

 (15 件のコメント) (1 件のリアクション) (0 人の担当者)JavaScript (279 件のフォーク)batch import
discussiongood first issuehelp wantedrefactor

Repository metrics

Stars
 (5,093 個のスター)
PR merge metrics
 (PR metrics pending)

説明

cc/ @kcolton @chriddyp @tarzzz

I'm starting this discussion prompted by issues:

  • #360 (poor performance of code editor)
  • #361 (duplicated sql-schemas requests)

Although the code editor lives in CodeEditorField.react.js and the schema preview in TableTree.react.js, it's very likely that we'll have to touch code in their parent components Preview.react.js and Settings.react.js.

I'd like to use this issue to discuss any significant changes to Preview.react.js and Settings.react.js before creating a PR.

コントリビューターガイド