playcanvas/engine

BoundingBox, BoundingSphere, OrientedBox extra methods.

Open

#858 opened on 2017年2月22日

GitHub で見る
 (2 comments) (0 reactions) (0 assignees)JavaScript (8,878 stars) (1,325 forks)batch import
enhancementgood first issue

説明

It worth finalizing consistency withing those three classes, so here is list of things to do:

BoundingBox

  1. Deprecate intersects and add another method intersectsBoundingBox which will have same functionality
  2. Add intersectsOrientedBox method
  3. Add center and halfExtents property reference

BoundingSphere

  1. Add intersectsBoundingBox method (calls box.intersectsBoundingSphere internally)
  2. Add intersectsOrientedBox method
  3. Add center and radius property reference

OrientedBox

  1. Add intersectsBoundingBox method (calls box.intersectsOrientedBox internally)
  2. Add intersectsOrientedBox method
  3. Add halfExtents property reference
  4. Property worldTransform has wrong reference

コントリビューターガイド

技術スタック
javascript
領域
frontend
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
3-5 days
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Basic 3D geometryJavaScriptFamiliarity with PlayCanvas engineUnderstanding of bounding volumes
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
60
調査方針
Locate the BoundingBox, BoundingSphere, and OrientedBox classes in the PlayCanvas engine codebase (likely in src/scene/). Review existing methods like intersects, intersectsBoundingSphere, and property references. For BoundingBox: deprecate intersects and add intersectsBoundingBox (same functionality), add intersectsOrientedBox, and add center and halfExtents property references. For BoundingSphere: add intersectsBoundingBox (calling box.intersectsBoundingSphere internally), add intersectsOrientedBox, and add center and radius property references. For OrientedBox: add intersectsBoundingBox (calling box.intersectsOrientedBox), add intersectsOrientedBox, add halfExtents property reference, and fix the worldTransform property reference. Ensure consistency and follow existing coding patterns. Check for any existing implementations or partial work.