pinojs/pino

bindings() and setBindings() are not present in the browser version of pino

Open

#1,177 opened on 2021年10月20日

GitHub で見る
 (3 comments) (0 reactions) (0 assignees)JavaScript (13,157 stars) (839 forks)batch import
enhancementgood first issue

説明

Hello!

I was attempting to use pino in the browser today and discovered that .bindings() is undefined. Additionally, .setBindings() is also undefined, but it's also undocumented in general (is it officially part of the API?).

I looked into adding this to browser.js but I'd definitely need some guidance before proceeding. For example, I'm not sure if bindings changes cascade through child loggers or if they are fixed at the time of child creation, for example.

コントリビューターガイド

技術スタック
javascript
領域
backendfrontend
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
needs maintainer response
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
familiarity with pino's APIknowledge of child logger behavior
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
60
調査方針
Start by examining the browser.js file in the repository to understand how the browser logger is implemented. Check the documentation for bindings() and setBindings() in the Node.js version. Look at how child loggers are created and if bindings are mutable. The issue author requested guidance, so it would be helpful to review any comments for additional context.
bindings() and setBindings() are not present in the browser version of pino · pinojs/pino#1177 | Good First Issue