pingcap/tidb

unix_timestamp return worng result when input with fractional digits

Open

#6,981 opened on 2018年7月4日

GitHub で見る
 (8 comments) (0 reactions) (0 assignees)Go (40,090 stars) (6,186 forks)batch import
component/expressionhelp wantedpriority/P4type/compatibility

説明

  1. What did you do? If possible, provide a recipe for reproducing the error.
mysql -P3306 -h127.0.0.1 -uroot -proot --column-type-info test;

mysql> select unix_timestamp('2011:01:01.001');
  1. What did you expect to see?
Field   1:  `unix_timestamp('2011:01:01.001')`
Catalog:    `def`
Database:   ``
Table:      ``
Org_table:  ``
Type:       LONGLONG
Collation:  binary (63)
Length:     11
Max_length: 10
Decimals:   0
Flags:      NOT_NULL BINARY NUM 

+----------------------------------+
| unix_timestamp('2011:01:01.001') |
+----------------------------------+
|                       1293814800 |
+----------------------------------+
1 row in set (0.00 sec)
  1. What did you see instead?
Field   1:  `unix_timestamp('2011:01:01.001')`
Catalog:    `def`
Database:   ``
Table:      ``
Org_table:  ``
Type:       NEWDECIMAL
Collation:  binary (63)
Length:     17
Max_length: 14
Decimals:   3
Flags:      BINARY NUM 


+----------------------------------+
| unix_timestamp('2011:01:01.001') |
+----------------------------------+
|                   1293811200.000 |
+----------------------------------+
1 row in set (0.00 sec)
  1. What version of TiDB are you using (tidb-server -V or run select tidb_version(); on TiDB)?
Release Version: v2.1.0-beta-11-g1f6e12cc5
Git Commit Hash: 1f6e12cc55e534bf514eef212f1091a91b8592c9
Git Branch: HEAD
UTC Build Time: 2018-07-04 06:31:26
GoVersion: go version go1.10.1 linux/amd64
Race Enabled: false
TiKV Min Version: 2.1.0-alpha.1-ff3dd160846b7d1aed9079c389fc188f7f5ea13e

コントリビューターガイド

技術スタック
gosql
領域
databasebackend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
Basic SQLFamiliarity with datetime functions
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
40
調査方針
Investigate the implementation of the `unix timestamp` function in TiDB's expression evaluation, likely in `expression/time func.go` or similar. Focus on how fractional seconds in input strings are parsed and handled. Examine the code that distinguishes between integer and decimal return types. Look for any existing tests for `unix timestamp` with fractional inputs and reproduce the issue. Consider whether the fix should adjust the return type to match MySQL's behavior (LONGLONG with integer result) or ensure correct rounding.