executor.Next() should not call chid.Open() or child.Close() · pingcap/tidb#4983

(1 comment) (0 reactions) (1 assignee)Go (40,090 stars) (6,186 forks)batch import

help wanted

説明

calling Open() or Close() during Next() makes our executors un-maintainable, for example, if we comment out the following lines then make test, our ut failes ... https://github.com/pingcap/tidb/blob/0616a2fd1511e2206086c212261d93b1106605c7/executor/executor.go#L345

or https://github.com/pingcap/tidb/blob/0616a2fd1511e2206086c212261d93b1106605c7/executor/join.go#L88

Open is used to initialize executors and allocate resources for every executor Close is used to deallocate the resource adopted by every executor, avoid memory leak

コントリビューターガイド

技術スタック: go
領域: backend
Issue 種別: bug
難度: 3
推定時間: 1-2 days
活動状況: stale
明確さ: clear
前提条件: Go programmingunderstanding of executor lifecycle
初心者向け度: 20
調査方針: Examine the references in executor/executor.go and executor/join.go to understand the current pattern. Determine the correct places to call Open and Close without violating the Next contract. Ensure that existing tests pass after the refactoring, as noted in the issue that tests fail with current code. Consider the wider executor hierarchy to maintain consistency.