pingcap/tidb

use monotonic time directly instead of Go time in somewhere

Open

#32,121 opened on 2022年2月7日

GitHub で見る
 (6 comments) (3 reactions) (1 assignee)Go (6,186 forks)batch import
help wantedtype/enhancementtype/performance

Repository metrics

Stars
 (40,090 stars)
PR merge metrics
 (平均マージ 14d 4h) (30d で 346 merged PRs)

説明

Enhancement

In TiDB, we heavily use Go time.Now to calculate the duration of some operations, e.g. prometheus Histogram, query time, etc.

For time.Now, this function will call walltime and nanotime, but in the above scenario, we only need to call nanotime(monotonic clock) to calculate the duration.

import _ "unsafe"
//go:noescape
//go:linkname nanotime runtime.nanotime
func nanotime() int64

func Now() time.Duration {
	return time.Duration(nanotime())
}

Here is a simple implementation for Nanotime,


func BenchmarkTime1(b *testing.B) {
	for i := 0; i < b.N; i++ {
		time.Now()
	}
}

func BenchmarkTime2(b *testing.B) {
	for i := 0; i < b.N; i++ {
		Now()
	}
}

The benchmark result is:

BenchmarkTime1-8          	17705235	        65.90 ns/op
BenchmarkTime2-8          	38601799	        29.68 ns/op

コントリビューターガイド