pingcap/tidb

Avoid double-copy buffer when responding MySQL packets

Open

#32,097 opened on 2022年2月3日

GitHub で見る
 (3 comments) (0 reactions) (1 assignee)Go (6,186 forks)batch import
help wantedtype/enhancementtype/performance

Repository metrics

Stars
 (40,090 stars)
PR merge metrics
 (平均マージ 14d 4h) (30d で 346 merged PRs)

説明

Enhancement

When we want to return the packages to the client, our logic is:

  1. Prepare the packet and serialize it to a buffer allocated by the area.Allocator
  2. Write this data through packetIO.WritePacket, in the WritePacket, the data will be cached in a buffer writer
  3. Flush the buffer writer to the connection

Mostly, e.g, for write ok https://github.com/pingcap/tidb/blob/0c19f927419f6b043a345e4a2af5336272830229/server/conn.go#L1442, we can see that we don't need to double copy the buffer, we can serialize the data and write it directly to the connection.

コントリビューターガイド