pingcap/tidb

Imporve the performance of writing chunks to connection.

Open

#13,052 opened on 2019年10月31日

GitHub で見る
 (1 comment) (1 reaction) (0 assignees)Go (40,090 stars) (6,186 forks)batch import
component/serverhelp wantedtype/enhancementtype/performance

説明

Feature Request

Is your feature request related to a problem? Please describe:

In https://github.com/pingcap/tidb/blob/7bfa896/server/conn.go#L1269, we have a chunk to write to connection, but we dump a chunk to mysql protocol row by row.

Describe the feature you'd like:

Now we can vectorize dumpBinaryRow and dumpTextRow by converting a chunk to network buffer column by column.

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

コントリビューターガイド

技術スタック
gosql
領域
backenddatabaseperformance
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
4
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
3-5 days
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
GoTiDB internalsMySQL protocolperformance optimization
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
20
調査方針
The issue asks to vectorize `dumpBinaryRow` and `dumpTextRow` in `server/conn.go` at line 1269. Currently, the chunk is written row by row. The solution involves converting a chunk to network buffer column by column. To implement this, first understand the current row by row dumping logic and the Chunk structure in TiDB. Then design a columnar conversion that writes all rows for one column before moving to the next. Benchmarks should be created to measure performance improvement. No existing PRs or assignees; the issue is from 2019, so re evaluate with current codebase and discuss with maintainers.