palantir/blueprint

Add bordered prop to the Section component

Open

#6,577 opened on 2023年11月30日

GitHub で見る
 (1 comment) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P2Package: coreType: feature requesthelp wanted

説明

Environment

  • Package version(s): BP5
  • Browser and OS versions:

Feature request

It would be nice to have a prop in the Section component called Bordered (similar to the CardList) that allows the consumer of the component to decide whether to render the border lines of Section.

In addition to removing the border, the gap between the title and the body of the section should be reduced to 15px when bordered is false. Removing just the border leaves too much space.

Examples

コントリビューターガイド

技術スタック
reacttypescriptcss
領域
frontend
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
fresh
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
ReactTypeScriptCSS
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
75
調査方針
Start by locating the Section component source file in the Blueprint repo (likely under packages/core/src/components/section/). Examine the existing Section component props and how the CardList component implements its 'bordered' prop for reference. Implement a new 'bordered' boolean prop that toggles the border and reduces the gap between title and body to 15px when false. Update the component's styles accordingly, possibly using CSS modules or Blueprint's style system. Ensure the changes are consistent with BP5 conventions. There is one comment on the issue from Feb 2024 asking for status, no PR linked.