palantir/blueprint

Circular Dependencies in Popover

Open

#5,061 opened on 2021年12月7日

GitHub で見る
 (0 comments) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
Domain: toolingP2Package: coreType: bughelp wanted

説明

Environment

  • Package version(s): 3.51.3
  • Operating System: macOS 12.0.1 (21A559)
  • Browser name and version: Chrome 96.0.4664.93

Code Sandbox

Link to a minimal repro (fork this code sandbox): I'm not sure how to view the yarn install --verbose output.

Steps to reproduce

  1. Run yarn install --verbose
  2. View output

Actual behavior

(!) Circular dependencies
../../node_modules/@blueprintjs/core/lib/esm/components/popover/popover.js -> ../../node_modules/@blueprintjs/core/lib/esm/components/tooltip/tooltip.js -> ../../node_modules/@blueprintjs/core/lib/esm/components/popover/popover.js
../../node_modules/@blueprintjs/core/lib/esm/components/menu/menu.js -> ../../node_modules/@blueprintjs/core/lib/esm/components/menu/menuItem.js -> ../../node_modules/@blueprintjs/core/lib/esm/components/menu/menu.js
../../node_modules/@blueprintjs/core/lib/esm/components/index.js -> ../../node_modules/@blueprintjs/core/lib/esm/components/hotkeys/index.js -> ../../node_modules/@blueprintjs/core/lib/esm/components/hotkeys/hotkeysTarget.js -> ../../node_modules/@blueprintjs/core/lib/esm/components/hotkeys/hotkeysEvents.js -> ../../node_modules/@blueprintjs/core/lib/esm/components/hotkeys/hotkeysDialog.js -> ../../node_modules/@blueprintjs/core/lib/esm/components/index.js
...and 7 more

Expected behavior

This package shouldn't have circular dependencies.

Possible solution

I'm trying to upgrade my repository to use Yarn 3 and this circular dependency, (which is now a warning) is escalated to an error when in CI environment, thus preventing me from using Yarn3.

コントリビューターガイド

技術スタック
typescriptreactnodejs
領域
frontendbuild system
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Understanding of circular dependenciesFamiliarity with ES module importsBasic knowledge of webpack export maps
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
50
調査方針
Investigate the three circular dependency chains reported: popover↔tooltip, menu↔menuItem, and the longer chain through hotkeys. Check if the cycles can be broken by extracting shared logic into a separate file or using dynamic imports. Look at the source files under packages/core/src/components/popover, tooltip, menu, and hotkeys to identify the import loops. Ensure the fix does not create new cycles or break existing functionality. Consider if the issue is related to barrel exports (index.ts files) and propose reorganizing imports to be more specific.