palantir/blueprint

[MultistepDialog] Allow side navigation to be disabled (e.g. when submitting)

Open

#4,872 opened on 2021年8月20日

GitHub で見る
 (3 comments) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P2Package: coreType: feature requesthelp wanted

説明

Environment

  • Package version(s): @blueprintjs/core@3.48.0

Feature Request

  1. Add a disabled prop to <MultistepDialog> that would allow the side navigation to be disabled (e.g when the dialog is being submitted)

  2. Perhaps if specified true (and ignored as false | undefined), it could also combine & override any individual disabled props for all the other steps' nextButtonProps and backButtonProps? (You can see in my Code Sandbox example, I am passing || submitting through to most of them)

Code Sandbox

https://codesandbox.io/s/blueprint-sandbox-multistepdialog-4di0d

Steps to reproduce

(Using the example in the Code Sandbox)

  1. Advance through each step of the <MultistepDialog> to the end.
  2. See how each step must be "valid" before you can progress.
  3. On the last step, click the "Submit" button to trigger a fake submit state.
  4. ❌ See that you can still navigate around between past steps via the side navigation whilst the form submit is ongoing.

コントリビューターガイド

技術スタック
typescriptreact
領域
frontend
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
ReactBlueprint component usageTypeScript basics
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
60
調査方針
Examine the MultistepDialog source code at `@blueprintjs/core` to understand the current side navigation implementation. Look for the component's props interface and how step navigation is handled. Consider adding a `disabled` prop that disables side navigation (e.g., during submission) and possibly overrides individual step button props. Review the code sandbox linked in the issue for reproduction context. Check for existing tests in the repository to ensure new behavior is covered.