palantir/blueprint

[InputGroup] Cannot set fill to false

オープン

#4,857 opened on 2021/08/14

 (1 件のコメント) (0 件のリアクション) (0 人の担当者)TypeScript (2,167 件のフォーク)batch import
P3Package: coreType: bughelp wanted

Repository metrics

Stars
 (20,263 個のスター)
PR merge metrics
 (平均マージ 43d 10h) (30d で 27 merged PRs)

説明

Environment

  • Package version(s): 3.47.0
  • Operating System: Windows 10
  • Browser name and version: Google Chrome - v92.0.4515.131 (Official Build) (64-bit)

Code Sandbox

Link to a minimal repro: https://codesandbox.io/s/blueprint-sandbox-forked-68yys?file=/src/CoreExample.tsx

Steps to reproduce

  1. Create an InputGroup with fill=true
  2. Create another InputGroup with fill=false
  3. Both inputs look the same

Actual behavior

The fill prop cannot be set to false

Expected behavior

Setting the fill prop to false should make the component not to take up the full width of its container

Possible solution

TBH I'm not sure what's the solution for this one. I tried moving some styles in .bp3-input-group and .bp3-input, but doing so breaks a lot of components that depend on other inputs that are also using those classes (that's something I hate about CSS classes. To me It's so good we have styled-components now 😅)

コントリビューターガイド