palantir/blueprint

Editable Cell with enableFocusedCell stealing focus

Open

#4,796 opened on 2021年7月2日

GitHub で見る
 (0 comments) (1 reaction) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P2Package: tableType: bughelp wanted

説明

Environment

Package version(s): @blueprintjs/table 3.7.1 Operating System: MacOS Catalina 10.15.7 Browser name and version: Chrome Version 91.0.4472.114

Code Sandbox

https://codesandbox.io/s/enablefocusedcell-bug-0m19u

Steps to reproduce

  1. Enter a value into any cell (do not do anything to confirm the value ie press enter)
  2. Click the red div (or anywhere outside the table...thus confirming the cell)
  3. press any key
  4. See the cell listens for the keypress

Actual behavior

Although there has been an interaction outside of the table, the cell is still the active element (see console) and steals the next keypress.

Expected behavior

I would expect once there has been a user interaction outside the table, the cell should not listen for keypresses.

Possible solution

I believe the focus is being forced by this function which runs on every render https://github.com/palantir/blueprint/blob/5c05ce6bb12a9810b9ff35310a1554a65af6b65d/packages/table/src/cell/editableCell.tsx#L214-L219

コントリビューターガイド

技術スタック
typescriptreact
領域
frontend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
fresh
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
ReactDOM focus events
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
60
調査方針
The issue indicates that the `editableCell` component forces focus on every render via the `handleCellFocus` function in `packages/table/src/cell/editableCell.tsx` (lines 214-219). To fix, investigate why focus is being forced and ensure it only occurs when the cell should be focused, not after user interaction outside the table. Consider checking if the cell is still the active element or if a blur event has occurred.