palantir/blueprint

Popover v2 always take focus even if autoFocus is disabled

Open

#4,792 opened on 2021年7月2日

GitHub で見る
 (10 comments) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P2Package: popover2Type: bughelp wanted

説明

Environment

  • Package version(s): "@blueprintjs/core": "^3.46.0", "@blueprintjs/popover2": "^0.11.0",
  • Operating System: Mac OS, Big Sur 11.4
  • Browser name and version: Chrome Version 91.0.4472.114 (Build officiel) (x86_64)

Code Sandbox

https://codesandbox.io/s/restless-dust-b4ggf?file=/src/App.tsx

Context

I'm trying to create a component that behave close to Suggest but i can't rely on InputGroup. I try to build my own version but i'm blocked with popover v2 because focus is always take by the popover even if autoFocus props is marked as false.

Actual behavior

Input lose focus when popover open or close event if autoFocus is disabled.

Expected behavior

When autoFocus is disabled popover is not focus when open or close.

コントリビューターガイド

技術スタック
typescriptreact
領域
frontend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
fresh
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
ReactTypeScriptBlueprintJS
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
60
調査方針
Focus on the Popover2 component source in the @blueprintjs/popover2 package. Investigate the autoFocus prop handling in the open/close logic, specifically where focus is programmatically set. Check the Overlay component as it might manage focus. The issue reports that focus is always taken even when autoFocus is disabled; likely a missing conditional check.