palantir/blueprint

[select] On rerender / item list change, Suggest does not set active item to selected item

Open

#4,562 opened on 2021年3月4日

GitHub で見る
 (2 comments) (2 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P3Package: selectType: bughelp wanted

説明

Environment

  • Package version(s):
    • @blueprintjs/core: 3.39.0
    • @blueprintjs/select: 3.15.5
  • Operating System: all
  • Browser name and version: all

Code Sandbox

Link to a minimal repro: https://codesandbox.io/s/blueprint-sandbox-forked-rf75x?file=/src/index.tsx

Steps to reproduce

  1. Click Suggest input, note that 3 is active.
  2. Click "Reload item list," which simulates reloading list from network, etc.
  3. Click Suggest input, note that 1 is active instead 3, which is selected
  4. Blur focus on Suggest
  5. Click Suggest input again, note that active item finally resets to 3

Actual behavior

In step 3 above, the selected item is not active.

Expected behavior

In step 3, the selected item is active (assuming it's in the new list).

Possible solution

Might be that than maybeResetActiveItemToSelectedItem should be called in wider conditions than https://github.com/palantir/blueprint/blob/develop/packages/select/src/components/select/suggest.tsx#L157? But not too familiar with the implementation of Suggest.

コントリビューターガイド

技術スタック
typescriptreact
領域
frontend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
ReactTypeScriptBlueprint Suggest
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
55
調査方針
The issue describes that the Suggest component's active item does not reset to the selected item when the item list changes. The report includes a CodeSandbox reproduction and points to suggest.tsx line 157 where maybeResetActiveItemToSelectedItem is called. A potential fix is to call that function in broader conditions, such as when the items prop changes. The maintainer should review the component's lifecycle and ensure the active item is updated when the list updates.