palantir/blueprint

Some mechanism for letting EditableText shrink to its content size when not editing

Open

#4,543 opened on 2021年2月25日

GitHub で見る
 (0 comments) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P2Package: coreType: enhancementhelp wanted

説明

So this mostly already happens, but the min-width on the inner span is set to 80px. Have a UI like this:

Without doing some css hacking to unset the min-width, it ends up looking like this:

css hacking I'm doing is:

.display-name-value {
    max-width: 250px;

    > :last-child {
        // Need our EditableTexts to contract to their content size
        /* stylelint-disable declaration-no-important */
        min-width: unset !important;
        /* stylelint-enable declaration-no-important */
    }
}

but that's obviously really flaky, so was hoping for a more formal way to remove/lower the min-width (unset isn't necessarily correct because you get into a weird spot if you don't have a placeholder, but want the ability to make it lower than 80px at least)

コントリビューターガイド

技術スタック
typescriptreactcss
領域
frontend
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
ReactCSSBlueprint component basics
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
65
調査方針
Examine the EditableText component in the Blueprint repo (likely in packages/core/src/components/editable text). The issue requests a formal mechanism to control or remove the hardcoded min width on the inner span (currently 80px). Consider adding a prop like `shrinkToContent` or `minWidth` that defaults to 80px but can be set to smaller or 'unset'. Look at existing styling logic for the span and how props are passed to the component's state. No linked PRs or comments provide guidance, so the solution should be a non breaking addition.