palantir/blueprint

DateRangePicker with singleMonthOnly enabled sometimes shows wrong month after selecting shortcut

Open

#4,526 opened on 2021年2月15日

GitHub で見る
 (6 comments) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P2Package: datetimeType: bughelp wanted

説明

Environment

  • Package version(s): v3.38
  • Operating System: Linux/Windows
  • Browser name and version: Google Chrome v88

Code Sandbox

https://codesandbox.io/s/blueprint-sandbox-forked-j4ooz?file=/src/index.tsx

Steps to reproduce

ezgif-3-4c479ecd4a65

  1. Select (Past month) shortcut
  2. Select any of the smaller ranges shortcut from shortcut menu (Past week, Yesterday, Today)
  3. The selected range will not appear in the single month shown

Actual behavior

Selected range is inconsistent after toggling from past month to current week/day ranges from shortcut menu in single-month mode only.

Expected behavior

The calendar should show the month where the currently selected range is, instead of the previous one.

Possible solution

Not sure about the solution. Switching from past 3 month to current week/day works fine. Showing ending month as default may not also not be a correct solution as for higher ranges(6month,1 year), it will show the current month.

コントリビューターガイド

技術スタック
typescriptreact
領域
frontend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
ReactTypeScript
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
50
調査方針
Investigate the DateRangePicker component, specifically the logic for selecting shortcuts when singleMonthOnly is enabled. The issue suggests that switching from a past month shortcut to a current week/day shortcut does not update the displayed month correctly. Look at the shortcut selection handler and month navigation logic in the source file (likely src/components/date range picker/). Check if there is an existing fix or related PR mentioned in comments.