palantir/blueprint

Date Range Input: Time is not updating onHoverChange event

Open

#4,402 opened on 2020年11月8日

GitHub で見る
 (2 comments) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P3Package: datetimeType: bughelp wanted

説明

Environment

  • Package version(s): 3.30.1
  • Operating System: MAc OS Catlina
  • Browser name and version: Chrome latest

Code Sandbox

Actually the bug can be visible in the documentation itself so adding Screenshot of it here

Steps to reproduce

Enable Time Precision with minute or seconds

  1. Click Start Date Field (so Date Picker opens).
  2. Select preferred date for both start and end fields.
  3. Please Add time in the below boxes for hours, minutes, seconds.
  4. Now Hover the different date in Date Picker and you can see start date in input field changes as per the hover state but the time value will be the default time itself (12:00)
  5. The same happens in end date field too.

Actual behavior

As we can clearly see the time is not changing and stays still with 12:00 during hovering of dates

Expected behavior

We should get the time from the value and update the time too when we hover Defaulting to 12:00 and changing immediately back to user selected time causes confusion

Possible solution

DateRangePicker props and callback function should be updated with props time i guess

コントリビューターガイド

技術スタック
typescriptreact
領域
frontend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
ReactTypeScriptDateRangePicker API
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
55
調査方針
Investigate the DateRangePicker component, specifically the onHoverChange event handler. Check how time values are preserved during hover. Look at the source code for DateRangePicker in the Blueprint repository, likely in the 'packages/date time' folder. Review the props and state management for time precision settings. Consider if the time should be taken from the already selected value instead of defaulting to 12:00.
Date Range Input: Time is not updating onHoverChange event · palantir/blueprint#4402 | Good First Issue