NumericInput controlled mode warns about invalid value too often · palantir/blueprint#4327

(1 comment) (9 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import

P2Package: coreType: enhancementhelp wanted

説明

Environment

Package version(s): core 3.31.0

Steps to reproduce

set up <NumericInput value={this.state.value} onChange={(_v, value) => this.setState({ value })) />
type 0.

Actual behavior

in dev mode, the component complains that

<NumericInput> controlled value prop does not adhere to stepSize, min, and/or max constraints.

2020-09-10 13 38 22

Expected behavior

this should be allowed. what it actually means is that the string passed was not a full numeric entity, but it can still be parsed as a valid number, so it's ok.

Possible solution

change the validation logic

コントリビューターガイド

技術スタック: typescriptreact
領域: frontend
Issue 種別: bug
難度: 3
推定時間: 1-2 days
活動状況: fresh
明確さ: mostly clear
前提条件: ReactTypeScriptBlueprint basics
初心者向け度: 60
調査方針: Investigate the NumericInput component's validation logic, likely in src/components/forms/numericInput.tsx or similar. The current validation rejects strings like '0.' that are not full numeric entities but parse to valid numbers. The fix should allow such intermediate values during typing while still enforcing constraints on final value. Consider using a regex or parsing function that accepts incomplete numbers.