palantir/blueprint

FR: components should be able to operate in child window documents

Open

#3,972 opened on 2020年2月19日

GitHub で見る
 (0 comments) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
Package: coreType: feature requesthelp wanted

説明

currently, some components like (e.g. NumericInput) reference window.document implicitly, which can may not be the document of the window where the component is being rendered in the case of React portal techniques like this one. we should look into supporting this use case.

possible solution: define a blueprint React context which includes an optional field which sets this.document on all components

コントリビューターガイド

技術スタック
typescriptreact
領域
frontend
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-2 days
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
Familiarity with React ContextUnderstanding of React portal behaviorBasic knowledge of Blueprint component architecture
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
40
調査方針
The issue proposes a React context to allow components to reference a custom document object for child window support. The main file to examine is `packages/core/src/components/forms/numericInput.tsx` where `window.document` is used implicitly. The goal is to introduce a context with an optional `document` field and update components to use it. No linked PRs or existing work; the issue remains open with no comments. A newcomer should first understand how Blueprint uses React context (e.g., for theming) and then prototype a solution that overrides the document reference in components like NumericInput.