palantir/blueprint

TextArea with growVertically doesn't get decreased when removing text

Open

#3,860 opened on 2019年11月19日

GitHub で見る
 (3 comments) (4 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P2Package: coreType: enhancementhelp wanted

説明

Environment

  • Package version(s): 3.18.0
  • Browser and OS versions: Safari 13.0.3 running at macOS 10.15.1 (originally found this bug Electron 5.0.3 that comes with Chrome 73.0, macOS, Windows)

Reproducing example

Steps to reproduce

  1. Open link to the example above;
  2. Focus at the TextArea;
  3. Select all and remove text content from the TextArea, either remove in any other way.

Actual behavior

TextArea component doesn't decrease its height.

Expected behaviour

TextArea is decreasing height according to the content height.

Possible solution

As I can see, TextArea uses its scrollHeight property that, seems like won't change after height has been already set and the content is less than element height. So we could try to reset it's height to auto (or other little value like a 10px) and then set actual height from scrollHeight. But it may cause some jumping so needs tests in the real-world. Looking for another workarounds, so I'll return here in case of success.

Hope this is not a duplicate since it would be time blowing for me and you!⌛️

コントリビューターガイド

技術スタック
typescriptreacthtmlcss
領域
frontend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
fresh
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
ReactTypeScriptDOM manipulation basics
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
70
調査方針
Examine the TextArea component in Blueprint's source code, likely in packages/react components/src/components/textarea/textarea.tsx. The current implementation uses scrollHeight to set height when growVertically is enabled, but it does not account for content removal. A potential fix is to reset the height to 'auto' before reading scrollHeight to allow it to shrink. Test with the provided codesandbox example. Review comments for any additional context or constraints from maintainers.