palantir/blueprint

Wrong maxTime displayed in DateRangeInput with timePickerProps

Open

#3,509 opened on 2019年5月1日

GitHub で見る
 (2 comments) (3 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
Domain: APIP2Package: datetimeType: bughelp wanted

説明

Environment

  • Package version(s): @blueprintjs/core:3.15.1 @blueprintjs/datetime:3.9.0 react:16.8.6
  • Browser and OS versions: Google Chrome 74 Mozilla Firefox 66 Linux Mint 18.3

https://codesandbox.io/s/m7n7mvvoyy

Steps to reproduce

  1. In a DateRangeInput set the minDate and maxDate and use the same minDate and maxDate to supply minTime and maxTime (respectively) in said DateRangeInput's timePickerProps.
  2. Open the DateRangePicker by focusing in the input box.

Actual behavior

Notice that the times at the bottom of the DateRangePicker popover both contain the time taken from the minTime prop supplied. The time from the maxTime prop doesn't get applied.

Expected behavior

The time input on the left should contain the time extracted from the supplied minTime prop and the time input on the right should contain the time extracted from the supplied maxTime prop.

Possible solution

コントリビューターガイド

技術スタック
reacttypescript
領域
frontend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Basic knowledge of ReactUnderstanding of Blueprint's DateRangeInput component
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
75
調査方針
The issue is in the DateRangeInput component where the maxTime from timePickerProps is not applied to the right (end) time picker. Investigate how timePickerProps are split and passed to the two underlying DatePicker components in the file `src/components/date time/dateRangeInput.tsx`. Look for where the time picker props are assigned to each date picker, and ensure that minTime and maxTime are correctly mapped to the start and end pickers respectively. Check the component's internal state and prop handling logic.