palantir/blueprint

FR: Support small modifier for NumericInput

Open

#3,132 opened on 2018年11月7日

GitHub で見る
 (2 comments) (1 reaction) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P3Package: coreType: feature requesthelp wanted

説明

Environment

  • Package version(s): 3.8
  • Browser and OS versions: Chrome 70

Feature request

I like to make a form using small modifier on components. I can use small modifier on InputGroup and Button but MenuItem and NumericInput does not support small modifier. I tried className={Classes.SMALL} but it did not work. You can look at screenshot below as an example

Could you implement support for these components? Probably there are other components that does not support small modifier. I prefer support for all components which can be used inside a form.

Examples

<Button small={true} rightIcon="double-caret-vertical" .../> <InputGroup small={true} .../> <NumericInput leftIcon="arrow-top-left" .../> // does not support small modifier <NumericInput .../>

コントリビューターガイド

技術スタック
typescriptreact
領域
frontend
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Familiarity with Blueprint component patternsUnderstanding of TypeScript and React
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
60
調査方針
The issue requests adding a 'small' modifier to NumericInput, similar to existing support in Button and InputGroup. Research the implementation of the 'small' prop in those components (e.g., Button.tsx and InputGroup.tsx) to understand the pattern. Then examine NumericInput.tsx and its associated styles in numeric input.scss to add the Small modifier. The issue mentions that className={Classes.SMALL} did not work, so the fix likely involves adding a prop or CSS class that applies the small size styling. There are no linked PRs or maintainer comments, so the implementation is straightforward and can follow the existing pattern.