palantir/blueprint

Using EditableText in selected tree element leads to unreadable text

Open

#2,236 opened on 2018年3月14日

GitHub で見る
 (3 comments) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
Package: coreType: bughelp wanted

説明

Bug report

  • Package version(s):
    "@blueprintjs/core": "^2.0.0-rc.2",
    "@blueprintjs/icons": "^2.0.0-rc.2",
    "@blueprintjs/table": "^2.0.0-rc.2",
  • Browser and OS versions: Chrome 64.0.3282.186 on OS X

Steps to reproduce

  1. Create
  2. Add child element with EditableText as label
  3. Select element and start editing

Actual behavior

The editable text is unreadable because it's white text on white background.

style-problem

Expected behavior

Visibly different colors for text and background.

Shouldn't pt.editable-text.pt-editable-editing set the text-color when setting the background-color? Setting only one of them sounds like inviting this kind of problems.

コントリビューターガイド

技術スタック
typescriptreactcss
領域
frontend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
under 1 hour
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
CSSReact
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
80
調査方針
Investigate the CSS for the Tree component's selected state. The issue describes that when using EditableText as a label in a selected tree element, the text becomes unreadable due to white text on white background. Look at the CSS selector `.pt editable text.pt editable editing` and ensure that both `color` and `background color` are set appropriately. The fix likely involves adding a specific color override for the editing state within the selected tree element. Check the relevant SCSS files in the Blueprint codebase, such as those for Tree and EditableText components.
Using EditableText in selected tree element leads to unreadable text · palantir/blueprint#2236 | Good First Issue