oven-sh/bun

Misleading error message "URL must not be a blank string" when URL is a non-string value which does not stringify to a fully valid URL with a hostname

Open

#21,361 opened on 2025年7月24日

GitHub で見る
 (6 comments) (1 reaction) (0 assignees)Rust (90,348 stars) (4,486 forks)batch import
bugconfirmed buggood first issueweb:fetch

説明

What version of Bun is running?

1.2.18+0d4089ea7

What platform is your computer?

Darwin 24.3.0 arm64 arm

What steps can reproduce the bug?

Any of the following (and more):

await fetch(undefined)
await fetch(123)
await fetch({toString() {return `/some_path`}})

What is the expected behavior?

Something more precise, like:

fetch() URL must have a hostname

What do you see instead?

fetch() URL must not be a blank string

Additional information

Link to offending line in Bun sources: https://github.com/oven-sh/bun/blob/bd232189b4c39ac3c8ccef9cf0932407d65c527a/src/bun.js/webcore/fetch.zig#L1448

コントリビューターガイド

技術スタック
javascript
領域
backenddeveloper experience
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
fresh
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Understanding of Zig programmingFamiliarity with Bun's build systemBasic knowledge of JavaScript fetch API
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
75
調査方針
The issue is clearly described with the offending line at src/bun.js/webcore/fetch.zig:1448. The fix involves changing the error message string to be more specific about the URL missing a hostname. The contributor should examine the URL validation logic in that file to understand how the error is generated and ensure the new message is accurate. No linked PRs or additional comments provide further guidance.