openzfs/zfs

zfs holds -r does not work on non-snapshot datasets

Open

#9,822 opened on 2020年1月8日

GitHub で見る
 (3 comments) (0 reactions) (0 assignees)C (9,908 stars) (1,703 forks)batch import
Type: Defectgood first issue

説明

System information

Type Version/Name
Distribution Name Arch Linux
Distribution Version rolling
Linux Kernel 5.4.6
Architecture x86_64
ZFS Version 0.8.2-1
SPL Version 0.8.2-1

Describe the problem you're observing

If trying to list all of the holds on all of the snapshots on a dataset, I would expect zfs holds -r [dataset] to list, per snapshot, all of the holds. On FreeBSD 12.1 this works as expected. However, on ZFS on Linux it just says "not a snapshot" and lists nothing.

Describe how to reproduce the problem

  • Create a snapshot on a dataset
  • Create a hold on that snapshot
  • Run zfs holds -r [dataset]@[snapshot] and observe the hold
  • Run zfs holds -r [dataset] and observe the error

Include any warning/errors/backtraces from the system logs

N/A

コントリビューターガイド

技術スタック
c
領域
backend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
4
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-2 days
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
C programmingZFS command line toolsLinux/Unix system knowledge
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
25
調査方針
Investigate the implementation of the 'zfs holds r' command in the ZFS source code, specifically in the 'cmd/zfs/zfs main.c' file. The issue mentions that the recursive flag does not work on non snapshot datasets, while it works on FreeBSD. Look for how the ' r' flag is processed and how the dataset argument is handled. Compare the Linux and FreeBSD implementations if available. Check the man page for expected behavior and verify if there is any existing comment or code comment regarding this discrepancy. The issue has no linked PRs, so the fix would involve modifying the argument parsing or iteration logic to include snapshots when the ' r' flag is used.