openzfs/zfs

`zfs diff` shows pathes prefixed by mountpoint path (and sometimes irrelevant)

Open

#4,289 opened on 2016年1月30日

GitHub で見る
 (0 comments) (0 reactions) (0 assignees)C (9,908 stars) (1,703 forks)batch import
Status: InactiveType: Featuregood first issue

説明

Pathes which are printed by zfs diff are not dataset-relative; they include the dataset mountpoint. This creates additional troubles when scripting around zfs diff.

Moreover, if one diffs between two snapshots, output pathes are prefixed by the real dataset mountpoints (and not the relevant snapshot mountpoints). This makes even more troubles as the backup script now needs to have knowledge of completely irrelevant mountpoints. This part is probably related to #3325.

Example:

# mount | grep '^datastore2/Internal[@ ]'
datastore2/Internal@2016-01-24 on /mnt/datastore2@2016-01-24/datastore2-Internal type zfs (ro,relatime,xattr,posixacl)
datastore2/Internal@2016-01-28 on /mnt/datastore2@2016-01-28/datastore2-Internal type zfs (ro,relatime,xattr,posixacl)
datastore2/Internal on /mnt/data/Internal type zfs (ro,relatime,xattr,posixacl)

# zfs diff -FH datastore2/Internal@2016-01-24 datastore2/Internal@2016-01-28 | head -n5
M       /       /mnt/data/Internal/Misc/transmissionbt/.git/objects/eb
M       /       /mnt/data/Internal/Misc/transmissionbt/.git/objects/98
M       /       /mnt/data/Internal/Misc/transmissionbt/.git/objects/4f
M       /       /mnt/data/Internal/Misc/transmissionbt/.git/objects/e6
M       /       /mnt/data/Internal/Misc/transmissionbt/.git/objects/26

That is, pathes printed by mount diff are inside neither of snapshot mountpoints. They reference /mnt/data/Internal (the real dataset mountpoint), which the script knows nothing about.

コントリビューターガイド

技術スタック
c
領域
cli
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
4
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
over 1 week
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
C programmingZFS internalsfilesystem mountpoints
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
20
調査方針
Investigate the `zfs diff` command implementation in the OpenZFS codebase. The issue shows that output paths include the dataset mountpoint rather than being relative to the dataset. The fix likely involves changing how the path is determined, possibly by stripping the mountpoint prefix or using snapshot relative paths. Review existing code in `cmd/zfs/zfs diff.c` or similar files. Also consider the related issue #3325 for additional context.
`zfs diff` shows pathes prefixed by mountpoint path (and sometimes irrelevant) · openzfs/zfs#4289 | Good First Issue