Empty search produces weird download · openfoodfacts/openfoodfacts-server#9312

(7 comments) (0 reactions) (0 assignees)Perl (477 stars) (236 forks)batch import

good first issue🔎 Search

説明

What

When search.pl doesn't find any products, the CSV and XLSX are weird. Basically, HTTP response seems to contain some header for the resulting format, and the search result page that says "no results".

Steps to reproduce the behavior

Go to https://world-de.openfoodfacts.org/cgi/search.pl?action=process&tagtype_0=brands&tag_contains_0=does_not_contain&tag_0=M%C3%BCller&tagtype_1=brands&tag_contains_1=contains&tag_1=Muller&sort_by=unique_scans_n&page_size=20 to search for products that have the brand "Muller" but not the brand "Müller"
Notice that there are no results aside: Notice that pagination is presented, and one counter says there are 44 products, while another one shows 0 products.
Download the search results in XLSX and CSV format
Open the downloaded files in a text editor.

Expected behavior

An empty CSV/XLSX file should be provided for download.

Why

The downloads are provided with content-disposition: attachment;filename=openfoodfacts_export.xlsx or content-disposition: attachment;filename=openfoodfacts_export.csv headers. Users trying to open the files could get confused.

コントリビューターガイド

技術スタック: なし
領域: backenddata
Issue 種別: bug
難度: 3
推定時間: 1-3 hours
活動状況: stale
明確さ: clear
前提条件: Perlweb development basics
初心者向け度: 60
調査方針: Examine the search.pl script, focusing on the code that generates CSV and XLSX responses. Look for how the query result is checked before sending the file headers. Consider adding a conditional to output an empty spreadsheet or relevant headers when the search result set is empty. The issue also mentions a pagination inconsistency that may be related.