openfaas/ofc-bootstrap

Way to overrides values in template/gateway_config.yml

オープン

#154 opened on 2019/11/05

 (2 件のコメント) (0 件のリアクション) (1 人の担当者)Go (61 件のフォーク)auto 404
design/approvedgood first issuehelp wantedsize/mskill/beginner

Repository metrics

Stars
 (177 個のスター)
PR merge metrics
 (PR metrics pending)

説明

Today the templates/gateway_config.yml includes many essential values. Some of them are exposed to overrides in init.yaml But several are not. I think the best approach is to have default possible to override all "changeable" values. For gateway config template we are almost there, the are three values sticking out. L30-L32

Expected Behaviour

Possible to overrides the static values directly from init.yaml

Current Behaviour

All values are static

readonly_root_filesystem: true
scaling_min_limit: 1
scaling_max_limit: 4

Possible Solution

Add more values https://github.com/openfaas-incubator/ofc-bootstrap/blob/6accd2fbec50ea03f6775f0614e676fdaa0156dc/pkg/stack/stack.go#L39´ and set those values from ìnit.yaml

readonly_root_filesystem: {{.ReadonlyRootFileSystem}}
scaling_min_limit: {{.Scaling.MinLimit}}
scaling_max_limit: {{.Scaling.MaxLimit}}

コントリビューターガイド