openedx/openedx-platform

cleanup direct model imports from certificates djangoapp

オープン

#36,647 opened on 2025/05/01

 (4 件のコメント) (0 件のリアクション) (1 人の担当者)Python (4,331 件のフォーク)auto 404
good first issuehelp wanted

Repository metrics

Stars
 (8,150 個のスター)
PR merge metrics
 (PR metrics pending)

説明

There are a small number of direct imports from the certificates djangoapp's models.py. Wherever possible, we want to use the app's API) or data classes for use outside of the certificates app itself.

As of this writing, this appears to be all imports of the app that are not from api.py, data.py, test factories, the signals, or an exception definition:

the majority of them appear to be in legacy front-ends, unsurprisingly.

Acceptance Criteria

  • create any necessary data classes to get rid of direct imports of lms.djangoapps.certificates.models from outside the django app
  • change the code to reference the appropriate data class or API method
  • if it is difficult, costly, or impossible to make the change, consider adding a comment explaining why
  • verify that all the affected apps still work properly, and that all the tests pass

コントリビューターガイド