open-duelyst/duelyst

[P3] Repair and re-enable disabled SDK unit tests

Open

#25 opened on 2022年9月10日

GitHub で見る
 (0 comments) (0 reactions) (0 assignees)JavaScript (3,443 stars) (526 forks)batch import
backendenhancementfrontendhelp wanted

説明

Several unit tests have been disabled until we have time to go back and update them. search for Test disabled in the repo to find them:

% git grep -l 'Test disabled'
test/unit/sdk/ai/ai.js
test/unit/sdk/ai/bosses.js
test/unit/sdk/cards/bloodstorm/faction6.js
test/unit/sdk/cards/bloodstorm/neutrals.js
test/unit/sdk/cards/core/faction2/artifacts.js
test/unit/sdk/cards/core/faction3/minions.js
test/unit/sdk/cards/core/faction5/spells.js
test/unit/sdk/cards/core/neutrals/epics.js
test/unit/sdk/cards/coreshatter/faction1.js
test/unit/sdk/cards/misc/bloodborn_spells.js
test/unit/sdk/cards/monthlies/month7.js
test/unit/sdk/cards/monthlies/month9.js
test/unit/sdk/cards/monthlies/seven_sisters.js
test/unit/sdk/cards/shimzar/battle_pets.js
test/unit/sdk/cards/shimzar/faction1.js
test/unit/sdk/cards/shimzar/faction2.js
test/unit/sdk/cards/shimzar/faction4.js
test/unit/sdk/cards/shimzar/faction5.js
test/unit/sdk/cards/unity/faction5.js
test/unit/sdk/cards/unity/faction6.js
test/unit/sdk/cards/wartech/faction2.js
test/unit/sdk/cards/wartech/faction3.js
test/unit/sdk/cards/wartech/faction4.js
test/unit/sdk/cards/wartech/faction5.js
test/unit/sdk/game/basic.js

We should revisit these and turn them back on once we get them working.

コントリビューターガイド

技術スタック
javascript
領域
testing
Issue 種別
test
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-2 days
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
JavaScript programmingUnit testing experienceNode.js environment setup
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
55
調査方針
First, use git grep to locate files containing 'Test disabled' as listed in the issue (e.g., test/unit/sdk/ai/ai.js). For each file, examine the disabled test(s) and understand the logic. Look for comments or recent changes that caused the test to fail. Update the test code to fix any issues and remove the 'Test disabled' marker. Ensure all tests pass. The repository uses JavaScript and likely a testing framework like Mocha or Jest—check package.json for details. No linked PRs or assignees exist, so this is open for taking.
[P3] Repair and re-enable disabled SDK unit tests · open-duelyst/duelyst#25 | Good First Issue