onivim/oni

Can we move away from emulating neovim behavior for scrolling?

Open

#405 opened on 2017年4月26日

GitHub で見る
 (11 comments) (9 reactions) (0 assignees)TypeScript (11,389 stars) (336 forks)batch import
enhancementhelp wantedinsider

説明

I think the Grid implementation is a bit bad, and I don't mean that from an implementation perspective. The scrolling in oni, in my opinion, isn't worse than neovim. At least for me, it feels about the same. If we could somehow render a large (basically render ahead to a certain arbitrary point where it becomes not worth the benefit) portion of the Grid implementation but make it all on an actually scrollable page, we could just send a cursor position back to Neovim instead of sending scroll events. The issue with scroll events is that (especially on OSX) on modern laptops that have fast/inertia scrolling, it's just firing off too many times in a second.

コントリビューターガイド

技術スタック
typescript
領域
frontendperformance
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
4
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
3-5 days
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
Understanding of Oni Grid implementationFamiliarity with Neovim RPCExperience with rendering in TypeScript
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
25
調査方針
Examine the current Grid implementation in the Oni codebase, likely in the src/ directory, to understand how scrolling events are generated and handled. Review the comments on issue #405 for proposed alternatives, such as rendering a larger buffer and sending cursor position. Consider the performance implications of this change, especially on macOS with inertia scrolling. Look for any existing branches or discussions that might provide a starting point.