onivim/oni

React/Redux DevTools no longer working

Open

#2,611 opened on 2018年10月4日

GitHub で見る
 (2 comments) (0 reactions) (0 assignees)TypeScript (11,389 stars) (336 forks)batch import
developmentgood first issueinsiderregression

説明

The react and redux devtools seem to have regressed and are no longer available in dev. I think this might be due to a broken env variable OR the package might have changed and does not export the tools in the same way anymore.

My suggestion for anyone looking to tackle this would be to have a look at the DevToolsInstaller and confirm that the installer is being called and that the tools are correctly imported (I suspect they are undefined as we using a dynamic import which is likely broken due to a recent webpack upgrade)

コントリビューターガイド

技術スタック
typescriptreact
領域
frontenddeveloper experience
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
Understanding of React/Redux DevToolsFamiliarity with dynamic imports in Webpack
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
25
調査方針
Examine the DevToolsInstaller component in the codebase to confirm it is being called. Check if the dynamic import for React/Redux DevTools is broken due to a recent Webpack upgrade, as suspected. Also verify that the development environment variable is set correctly. Review any comments or linked PRs for additional context.