onivim/oni

Changing themes is buggy

Open

#2,470 opened on 2018年7月27日

GitHub で見る
 (8 comments) (1 reaction) (0 assignees)TypeScript (11,389 stars) (336 forks)batch import
0.3.8buggood first issue

説明

Oni Version: 0.3.6 Neovim Version (Linux only): Operating System: Microsoft Windows 10 x64 v1709, build nº16299.15

Issue: Changing themes is buggy and laggy it slows Oni down so much.

Expected behavior: Like in VSCode or Atom, when i select a theme, it instantaneously changes the actual theme to the new i selected. In Oni, this doesn't happen.

Actual behavior: It takes so much to change between themes, when i select one in the command palette, the screen flashes and the theme starts to load slowly. After about 5-10 seconds i can use Oni normally again.

Steps to reproduce: Just open up the command palette and select Themes => Choose theme and select any theme from the list.

I understand that this is still an experimental / beta version, but even with all the bugs, the development team is to be congratulated! It really is a beautiful job! Thank you :) 👍

コントリビューターガイド

技術スタック
typescript
領域
desktopfrontendperformance
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
3-5 days
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
TypeScriptOni theming systemperformance profiling
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
40
調査方針
Investigate the theme loading mechanism in Oni, likely in the UI layer (React or similar). Look at how theme changes trigger updates, possibly involving JSON parsing and CSS injection. Use browser developer tools (if applicable) or Node.js profiling to identify bottlenecks. The issue has no assigned developer, so it is open for contribution. Check the comments for any prior investigation.
Changing themes is buggy · onivim/oni#2470 | Good First Issue