onivim/oni

Feature - Command Palette: Allow specifying arguments for commands

Open

#1,960 opened on 2018年3月28日

GitHub で見る
 (1 comment) (0 reactions) (0 assignees)TypeScript (11,389 stars) (336 forks)batch import
enhancementhelp wantedinsider

説明

This came up in the context of #1947 - it'd be really convenient when opening a browser window to specify a URL, directly from the command palette:

For example, if I start typing bro and then a space and then http://onivim.io, that would make opening a web browser much more convenient.

Today, we can't do that, since our fuzzy filtering tries to match the whole search string: args-to-command

To implement this, we might need to add a custom filter strategy for the command palette window (such that it only uses the first token in the string), and then update the Tasks provider (which backs the command palette) to send back any arguments. That code is around here: https://github.com/onivim/oni/blob/8186d0ba5754282b81464748355ad702d5a4f8e5/browser/src/Services/Tasks.ts#L78

コントリビューターガイド

技術スタック
typescriptelectron
領域
frontend
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
TypeScriptOni development setup
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
65
調査方針
Research the current command palette implementation, particularly the fuzzy filter in the Tasks provider at browser/src/Services/Tasks.ts. Understand how commands are matched and executed. Consider adding a custom filter strategy that only uses the first token for matching, and pass the remaining tokens as arguments to the command. Also review any existing tests for command palette to ensure no regressions.