onivim/oni

TypeScript: Hook up auto-import functionality

Open

#1,593 opened on 2018年2月21日

GitHub で見る
 (12 comments) (3 reactions) (1 assignee)TypeScript (11,389 stars) (336 forks)batch import
bountybounty-100enhancementhelp wanted

説明

Splitting out from #1326 - integrate 'auto-import' functionality from TypeScript. This should generalize to other completion providers, too.

  • Implement additionalTextEdits and textEdit for CompletionItems as defined by the completion request in the language server protocol: https://microsoft.github.io/language-server-protocol/specification
  • Update our TypeScriptServerHost to send additionalTextEdits for auto-imports. This will involve settting the includeExternalModuleExports for the completions request, hooking up entry details resolution to get information about the additional code actions as part of the details request, and resolving those code actions to text edits. Looks like we'll need to plumb the 'source' through somehow, as this is needed when calling to get details.

コントリビューターガイド

技術スタック
typescript
領域
tooling
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
4
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
3-5 days
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
Basic understanding of TypeScriptFamiliarity with Language Server Protocol
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
25
調査方針
Review the LSP completion specification for additionalTextEdits and textEdit. Examine the TypeScriptServerHost code to understand current completion handling and how to set the includeExternalModuleExports flag. Check issue #1326 for context on auto import integration and investigate how to resolve code actions to text edits, possibly by plumbing the 'source' through the completion details request.