onivim/oni

Thoughts on the new global search

Open

#1,553 opened on 2018年2月14日

GitHub で見る
 (3 comments) (3 reactions) (0 assignees)TypeScript (11,389 stars) (336 forks)batch import
enhancementhelp wanted

説明

Hi all, I just updated to 0.3.0 which has the new "VS Code" style sidebar with global search and I wanted to give my input about an alternative implementation (I sincerely hope that no one takes any offence to this).

I personally prefer the approach to global search that emacs-helm, atom-narrow and unite.vim take. The advantages of this style of approach include:

  • You get a consistent UI for narrowing lists of different types of data sources instead of a specific UI for just global line-wise search (i.e. ripgrep). For example, with the tools listed above you can use to same UI for local symbol search, global symbol search, global line-wise search, local line-wise search, local folds and more
  • It can be made to be extensible (just like how you can add your own custom sources with unite.vim)
  • Quicker to visually parse because the input text field is co-located with the results
  • This last point is quite opinionated, but I also feel that this approach is more "vim-like"

Looking forward to hearing your thoughts on this :)

コントリビューターガイド

技術スタック
typescript
領域
design
Issue 種別
research
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
5
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
over 1 week
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
unclear
前提条件
なし
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
20
調査方針
This issue is a feature request to explore alternative UI approaches for global search, similar to emacs helm, atom narrow, and unite.vim. The discussion in the comments may provide additional context or maintainer feedback. To move forward, one should review Oni's current search implementation, understand its extensibility, and propose a design that unifies different search sources (e.g., symbols, lines, folds). The maintainers might have specific requirements or constraints that need to be addressed.