ocaml/dune

Flush output buffers on SIGTERM

オープン

#3,882 opened on 2020/10/21

 (12 件のコメント) (0 件のリアクション) (2 人の担当者)OCaml (478 件のフォーク)github user discovery
good first issue

Repository metrics

Stars
 (1,882 個のスター)
PR merge metrics
 (平均マージ 1d 20h) (30d で 345 merged PRs)

説明

We're currently using dune runtest in OCaml-CI as the standard way of running tests for a package. If some of the tests for a package get stuck in a deadlock, the CI job will kill the process after 60 minutes. Unfortunately, this means that the logs of the stalled test run are lost.

We could switch to using dune runtest --no-buffer in the CI, but this creates less readable (interleaved) test output. One possible alternative would be for Dune to flush its output buffers before responding to SIGTERM (probably keeping the old behaviour for SIGKILL). What do you think?

コントリビューターガイド