oakmac/parinfer

refactor tests / testing approach

オープン

#13 opened on 2020/09/06

 (0 件のコメント) (0 件のリアクション) (0 人の担当者)JavaScript (0 件のフォーク)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (11 個のスター)
PR merge metrics
 (30d に merged PR はありません)

説明

re: https://github.com/shaunlebron/parinfer/issues/168

I would like to move away from the "test cases in markdown files with custom parsing" approach.

I think the custom annotation syntax is valuable for seeing how Parinfer operates. The way it is currently parsed and used by the test suite is pretty opaque right now; I think the implementation could be cleaner.

Implementation TODO

  • separate the annotation syntax parsing / reconstruction into it's own library with dedicated test suite (possibly a separate repo?)
  • create a kidif file for each test case
  • give each test case a stable id (use the 1000's for indent mode, 2000's for paren mode, 3000's for smart mode)
    • done with PR #14
  • write a script that builds a markdown file from the test cases for readability / exploring how Parinfer works

コントリビューターガイド