nytimes/library

Make the Recently/Most Viewed Stories dropdown optional based on Datastore config

オープン

#28 opened on 2019/05/28

 (0 件のコメント) (0 件のリアクション) (0 人の担当者)JavaScript (148 件のフォーク)auto 404
enhancementgood first issue

Repository metrics

Stars
 (1,180 個のスター)
PR merge metrics
 (PR metrics pending)

説明

Dropdown with Datastore Indexes set up:

Context (Environment)

A Library instance without Datastore Indexes set up.

Expected Behavior

Since setting up Datastore Indexes is optional, there should not be a dropdown if the indexes aren't set up.

Actual Behavior

Even without the indexes set up, an empty window still drops down. Screen Shot 2019-05-20 at 1 16 41 PM

Possible Solution

Enable/disable the dropdown depending whether the Datastore API/indexes are set up on the GCP project.

コントリビューターガイド