nspcc-dev/neofs-node

node: Refactor using `StorageEngine` in `Object` service

オープン

#1,834 opened on 2022/10/04

 (0 件のコメント) (0 件のリアクション) (0 人の担当者)Go (49 件のフォーク)auto 404
I4S2U4enhancementgood first issueneofs-storage

Repository metrics

Stars
 (36 個のスター)
PR merge metrics
 (PR metrics pending)

説明

Object service server of storage node uses engine.StorageEngine type directly almost everywhere. Such code architecture doesn't allow to tune local storage behavior. For example, in #1798 there was a need to block all local operations, but on Object server only: Control service should still call the engine.

I propose to refactor engine's usage as it done it ObjectService.Put server

https://github.com/nspcc-dev/neofs-node/blob/4eb0ed11f8e56beee3dfbee632cb4b9cad3bb47c/pkg/services/object/put/local.go#L11-L16

Each component should precisely document expected behavior of local object storage by itself via locally defined interface. As a bonus, instance can be easily mocked for testing.

コントリビューターガイド