nodejs/node

test_runner: do not read from `process.argv` and `process.cwd()` in run()

オープン

#53,867 opened on 2024/07/16

 (14 件のコメント) (5 件のリアクション) (0 人の担当者)JavaScript (35,535 件のフォーク)batch import
good first issuetest_runner

Repository metrics

Stars
 (117,218 個のスター)
PR merge metrics
 (PR metrics pending)

説明

Currently the codebase for https://github.com/nodejs/node/blob/362afa52ebe462a39874915e5e70d261db153c58/lib/internal/test_runner/runner.js#L472 accesses some poperties of process, capturing some options there. However, we also expose run() to the end users, therefore we should capture all this information in https://github.com/nodejs/node/blob/362afa52ebe462a39874915e5e70d261db153c58/lib/internal/main/test_runner.js#L68 and pass it down to run() as options.

コントリビューターガイド