nodejs/node

Re-enable test-ubsan.yml

クローズ

#52,753 opened on 2024/04/29

 (2 件のコメント) (0 件のリアクション) (0 人の担当者)JavaScript (35,535 件のフォーク)batch import
help wantedmetastale

Repository metrics

Stars
 (117,218 個のスター)
PR merge metrics
 (平均マージ 18d 17h) (30d で 219 merged PRs)

説明

During the latest Node.js major release (https://github.com/nodejs/node/pull/52505) we have had to disable test-ubsan.yml due to failing tests on a recent V8 update (https://github.com/nodejs/node/pull/52560).

I have tried to make it work, but due to the short time frame I had to fix it, we have decided to simply disable it for now.

Some insights:

  • It seems clang provides a better output and some docs we could use in the suppressions file.
    • Changing from g++ to clang for UBSAN will require changing all the suppression file

コントリビューターガイド